Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lm_sensors: fix cross-compilation #99583

Merged
merged 1 commit into from Oct 8, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

CC and AR need to be specified for cross-compilation to work.

@ofborg build pkgsCross.armv7l-hf-multiplatform.lm_sensors lm_sensors

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @dtzWill @Ericson2314

@lopsided98
Copy link
Contributor Author

@ofborg build pkgsCross.armv7l-hf-multiplatform.lm_sensors

@lopsided98
Copy link
Contributor Author

@ofborg build pkgsCross.armv7l-hf-multiplatform.lm_sensors

@Ericson2314 Ericson2314 merged commit e4538ab into NixOS:master Oct 8, 2020
@lopsided98 lopsided98 deleted the lm-sensors-cross branch October 8, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants