Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tilem: init at 2.0 #99572

Merged
merged 1 commit into from Oct 16, 2020
Merged

tilem: init at 2.0 #99572

merged 1 commit into from Oct 16, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Oct 4, 2020 •
edited

Motivation for this change

Add tilem emulator

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

OPNA2608
OPNA2608 requested changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tilibs, you should prolly fetch them from the upstream project instead.

https://sourceforge.net/projects/tilp/files/tilp2-linux/tilp2-1.18/

pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/tilem/default.nix Outdated Show resolved Hide resolved
@siraben siraben force-pushed the tilem-init branch 2 times, most recently from a702147 to cd4b859 Compare October 5, 2020 09:41
OPNA2608
OPNA2608 requested changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll wanna set meta.platforms to whatever platforms this package is supposed to be available on, and you might wanna run this through nixpkgs-fmt. Do you think/know if those libraries are used in any other projects? LGTM otherwise.

@siraben
Copy link
Member Author

siraben commented Oct 11, 2020 •
edited

Just ran it through nixpkgs-fmt, and set meta.platforms = platforms.linux ++ platforms.darwin;. I don't think the libraries are used in any other projects ATM, if they were in the future, should I make separate derivations for the libraries?

@siraben siraben requested a review from OPNA2608 October 13, 2020 12:25
OPNA2608
OPNA2608 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu 18.04, binary builds & launches, though I can't test beyond the ROM selection dialogue. Don't think I have the permissions to kick off a x86_64-darwin build on ofborg (and they recently seem to get stuck anyway?) so that unfortunately goes untested.

I don't think the libraries are used in any other projects ATM, if they were in the future, should I make separate derivations for the libraries?

I think it'd make sense to do it now, to avoiding accidental repackages later on or if a user needs only those libraries locally. IMO as it is seems acceptable to me too since they're fairly specific to the application, so I'll leave it up to you. LGTM

@siraben
Copy link
Member Author

siraben commented Oct 13, 2020

I tested on x86_64-darwin and NixOS, it runs as expected when given a ROM (e.g. https://github.com/siraben/zkeme80).

IMO as it is seems acceptable to me too since they're fairly specific to the application, so I'll leave it up to you.

I think it's ready for merge then!

@siraben siraben requested a review from OPNA2608 October 13, 2020 20:32
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/335

@OPNA2608
Copy link
Contributor

Whoops, wrong thread…

requested a review

Don't have merge permissions, sorry. Can only forward the PR to somehow who does.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/246

@AndersonTorres AndersonTorres merged commit 4669a06 into NixOS:master Oct 16, 2020
@siraben siraben deleted the tilem-init branch October 16, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien Awaiting requested review from symphorien

@OPNA2608 OPNA2608 Awaiting requested review from OPNA2608

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@siraben @nixos-discourse @OPNA2608 @symphorien @AndersonTorres