Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enlightenment.efl: enable wayland client support #99556

Merged
merged 4 commits into from Oct 11, 2020
Merged

enlightenment.efl: enable wayland client support #99556

merged 4 commits into from Oct 11, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Oct 4, 2020 •
edited

Motivation for this change

enlightenment.efl: enable wayland client support
enlightenment.efl: use pkg-config instead of the alias pkgconfig
enlightenment.efl: fix license
enlightenment.efl: remove leftover patch file

Fixes #98659

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo mentioned this pull request Oct 4, 2020
Closed
@romildo
Copy link
Contributor Author

romildo commented Oct 5, 2020

Result of nixpkgs-review pr 99556 1

10 packages built:
  • enlightenment.econnman
  • enlightenment.efl
  • enlightenment.enlightenment
  • enlightenment.ephoto
  • enlightenment.evisum
  • enlightenment.rage
  • enlightenment.terminology
  • python27Packages.pythonefl
  • python37Packages.pythonefl
  • python38Packages.pythonefl

@romildo romildo requested a review from jtojnar October 5, 2020 12:32
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/322

@worldofpeace worldofpeace merged commit f93d9fe into NixOS:master Oct 11, 2020
@worldofpeace
Copy link
Contributor

I'm half expecting some sort of change in the nixos module?

@romildo
Copy link
Contributor Author

romildo commented Oct 11, 2020

@worldofpeace , thank you for reviewing and merging this PR.

I'm half expecting some sort of change in the nixos module?

Do you mean changes in the nixos module related to wayland?

This PR does not enable running the Enlightenment DE on wayland yet. It just enables running EFL applications (like terminology) on any DE on wayland, like sway.

@romildo romildo deleted the upd.efl branch October 11, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@matejc matejc Awaiting requested review from matejc

@ftrvxmtrx ftrvxmtrx Awaiting requested review from ftrvxmtrx

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminology fails to start on Wayland: Xlib: extension "DPMS" missing on display ":0"
3 participants
@romildo @nixos-discourse @worldofpeace