Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: 0.18.3 -> 0.19.0 #99577

Merged
merged 2 commits into from Oct 5, 2020
Merged

kitty: 0.18.3 -> 0.19.0 #99577

merged 2 commits into from Oct 5, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Oct 4, 2020

Motivation for this change

https://github.com/kovidgoyal/kitty/releases/tag/v0.19.0

This release requires a new dependency.
There is now a flag for the build system to disable LTO. This removes the need for a patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
kitty: disable hardening feature based on more accurate condition
11deddb 
The `strictoverflow` hardening feature causes a build failure when using Clang as the compiler, not just on Darwin.
@Luflosi
kitty: 0.18.3 -> 0.19.0
5359c18 
https://github.com/kovidgoyal/kitty/releases/tag/v0.19.0

This release requires a new dependency.
There is now a flag for the build system to disable LTO. This removes the need for a patch.
@ofborg ofborg bot requested a review from tex October 4, 2020 19:38
hugolgst
hugolgst approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@hugolgst hugolgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Result of nixpkgs-review pr 99577

1 package built:
kitty

@danieldk danieldk merged commit f4e6fec into NixOS:master Oct 5, 2020
@Luflosi Luflosi deleted the update/kitty branch October 5, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst hugolgst approved these changes

@tex tex Awaiting requested review from tex

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Luflosi @hugolgst @danieldk