Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nzbhydra2: init at 3.8.0 #99559

Merged
merged 2 commits into from Jan 9, 2021
Merged

nzbhydra2: init at 3.8.0 #99559

merged 2 commits into from Jan 9, 2021

Conversation

JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Oct 4, 2020 •
edited

Motivation for this change

Closes #76878

Use the AUR package and jackett.nix as guidance on how to package NZBHydra2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Oct 4, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service is looking good. I have left a few comments that I think would improve it. I hope you find my comments helpful.

I generally only review modules, not packages, so we'll need to have someone review the package as well.

nixos/modules/services/misc/nzbhydra2.nix Outdated Show resolved Hide resolved
nixos/modules/misc/ids.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/nzbhydra2.nix Show resolved Hide resolved
aanderse
aanderse approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the module.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/345

SuperSandro2000
SuperSandro2000 reviewed Nov 27, 2020
View reviewed changes
pkgs/servers/nzbhydra2/default.nix Outdated Show resolved Hide resolved
pkgs/servers/nzbhydra2/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@JamieMagee Please resolve the merge conflcit.

@JamieMagee
Copy link
Member Author

@SuperSandro2000 Ready for review

@JamieMagee
Copy link
Member Author

Pushed an update from 2.29.1 to 3.8.0.

@aanderse I had to remove the MemoryDenyWriteExecute = true; in order to get OpenJDK to run. Otherwise it would fail with

OpenJDK 64-Bit Server VM warning: INFO: os::commit_memory(0x00007f9e8b2c3000, 2555904, 1) failed; error='Operation not permitted' (errno=1)

@JamieMagee
Copy link
Member Author

@ofborg eval

@aanderse
Copy link
Member

aanderse commented Jan 3, 2021

@SuperSandro2000 I propose merge - any outstanding issues from your point of view?

@JamieMagee
Copy link
Member Author

@aanderse It appears there are no concerns?

@aanderse
Copy link
Member

aanderse commented Jan 9, 2021

@JamieMagee sure. I'll assume @SuperSandro2000 is good with the package and merge once the bot runs your test.

Thanks for contributing to nixpkgs!

@GrahamcOfBorg test nzbhydra2

@aanderse aanderse changed the title Nzbhydra2 nzbhydra2: init at 3.8.0 Jan 9, 2021
@aanderse aanderse merged commit 4b0a2ac into NixOS:master Jan 9, 2021
@JamieMagee JamieMagee deleted the nzbhydra2 branch January 9, 2021 19:24
@tfmoraes tfmoraes mentioned this pull request Jan 9, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package request: nzbhydra2
4 participants
@JamieMagee @nixos-discourse @SuperSandro2000 @aanderse