iconnconfig: init at 0.5.2-beta #99598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugolgst
suggested changes
Oct 5, 2020
worldofpeace
reviewed
Oct 5, 2020
Added missing "v" prefix to fetchGit |
SuperSandro2000
requested changes
Nov 27, 2020
ezemtsov
force-pushed
the
iconnconfig
branch
from
c742100
to
86b2a1c
Compare
ezemtsov
force-pushed
the
iconnconfig
branch
2 times, most recently
from
1f66cc0
to
75e5443
Compare
|
Please also comment on #99598 (comment) |
|
Please squash the review commit into the package. |
|
Result of 1 package built:
|
done |
|
Result of 1 package built:
|
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Comment on lines
+12
to
+18
| src = fetchgit { | ||
| url = "https://codeberg.org/dehnhardt/IConnConfig"; | ||
| rev = "v${version}"; | ||
| sha256 = "10g0cgqkpqgwnbjdndhmyk4h680kbmlws3mc678fmgjy75qvbfmj"; | ||
| }; | ||
|
|
||
| PKControls = fetchgit { |
There was a problem hiding this comment.
Those should use fetchFromGitea with the domain pointing to codeberg.
stale
bot
removed
the
2.status: stale
stale
bot
added
the
2.status: stale
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
stale
bot
removed
the
2.status: stale
|
Closing as author usually takes very long to respond to review feedback and this open since years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
iConnConfig - an open source version of control software for iConnectivity devices.
Tested with my iConnectMidi4+
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)