Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upper-triangular matrices #2748

Merged
merged 5 commits into from
Oct 4, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 4, 2020

This will come handy for QR decomposition in the context of #2400.

friend class UnboundedUpperTriangularMatrix;
};

// For 0 < i <= j < columns, the entry a_ij is accessed as |a[i][j]|.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 ≤ i ≤ j < columns.

private:
explicit Row(Reference reference, int row);

Reference reference_;
Copy link
Member

@eggrobin eggrobin Oct 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factor the &, and use the language, rather than the identifiers, to say that it is a reference:

typename Referencetypename QualifiedMatrix

Reference reference_QualifiedMatrix& matrix_ (or that_ if you prefer that king of cleverness)

Row<UnboundedUpperTriangularMatrix&>Row<UnboundedUpperTriangularMatrix>
Row<UnboundedUpperTriangularMatrix const&>Row<UnboundedUpperTriangularMatrix const>

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Oct 4, 2020
@pleroy pleroy merged commit 599f202 into mockingbirdnest:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants