Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dask: limit processes on tests #99575

Merged
merged 6 commits into from Oct 4, 2020
Merged

python3Packages.dask: limit processes on tests #99575

merged 6 commits into from Oct 4, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 4, 2020 •
edited

Motivation for this change

this consistently fails on my server which is passing it 32 cores.

creates a lot of noise when reviewing python packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/99575
1 package marked as broken and skipped:
python37Packages.rl-coach

60 packages built:
python37Packages.aplpy python37Packages.batchgenerators python37Packages.caffe python37Packages.clifford python37Packages.dask python37Packages.dask-gateway python37Packages.dask-glm python37Packages.dask-image python37Packages.dask-jobqueue python37Packages.dask-ml python37Packages.dask-mpi python37Packages.dask-xgboost python37Packages.datashader python37Packages.distributed python37Packages.glymur python37Packages.image-match python37Packages.imagecorruptions python37Packages.imgaug python37Packages.intake python37Packages.mask-rcnn python37Packages.pims python37Packages.pyfftw python37Packages.scikitimage python37Packages.sparse python37Packages.spectral-cube python37Packages.streamz python37Packages.stumpy python37Packages.stytra python37Packages.sunpy python37Packages.tensorly python38Packages.aplpy python38Packages.batchgenerators python38Packages.caffe python38Packages.clifford python38Packages.dask python38Packages.dask-gateway python38Packages.dask-glm python38Packages.dask-image python38Packages.dask-jobqueue python38Packages.dask-ml python38Packages.dask-mpi python38Packages.dask-xgboost python38Packages.datashader python38Packages.distributed python38Packages.glymur python38Packages.image-match python38Packages.imagecorruptions python38Packages.imgaug python38Packages.intake python38Packages.mask-rcnn python38Packages.pims python38Packages.pyfftw python38Packages.scikitimage python38Packages.sparse python38Packages.spectral-cube python38Packages.streamz python38Packages.stumpy python38Packages.stytra python38Packages.sunpy python38Packages.tensor

@jonringer jonringer requested a review from FRidh as a code owner October 4, 2020 16:54
@jonringer jonringer mentioned this pull request Oct 4, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from bcdarwin and costrouc October 4, 2020 19:52
@ofborg ofborg bot requested a review from Rakesh4G October 4, 2020 20:15
@jonringer
Copy link
Contributor Author

the datashader tests still take way longer than I care for, but at least they aren't consistently failing like they were

@jonringer
Copy link
Contributor Author

anyway, these failures are making it harder to review other PRs without know if they introduced regressions.

@jonringer jonringer merged commit c65c94d into NixOS:master Oct 4, 2020
@jonringer jonringer deleted the fix-dask branch October 7, 2020 21:08
@risicle
Copy link
Contributor

risicle commented Oct 9, 2020

We could do with this in release-20.09

@risicle risicle added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 9, 2020
@jonringer jonringer mentioned this pull request Oct 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

@costrouc costrouc Awaiting requested review from costrouc

@Rakesh4G Rakesh4G Awaiting requested review from Rakesh4G

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @risicle