Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bmon: fix cross-compilation #99580

Merged
merged 1 commit into from Oct 11, 2020
Merged

bmon: fix cross-compilation #99580

merged 1 commit into from Oct 11, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

PKG_CONFIG must be an absolute path, otherwise the build fails with the following error:

configure: error: 
      *** The pkg-config script could not be found. Make sure it is
      *** in your path, or set the PKG_CONFIG environment variable
      *** to the full path to pkg-config.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @bjornfor @pSub

@lopsided98
Copy link
Contributor Author

@ofborg build pkgsCross.armv7l-hf-multiplatform.bmon

@ofborg ofborg bot requested review from bjornfor and pSub October 4, 2020 19:50
bjornfor
bjornfor approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could use command -v instead of type -p, for portability?

@bjornfor bjornfor added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Oct 5, 2020
@lopsided98
bmon: fix cross-compilation
ba4a9ef 
$PKG_CONFIG must be an absolute path
@lopsided98
Copy link
Contributor Author

Ok, done.

@ofborg ofborg bot requested a review from bjornfor October 5, 2020 04:53
@bjornfor bjornfor merged commit 0c97fff into NixOS:master Oct 11, 2020
@lopsided98 lopsided98 deleted the bmon-cross branch October 11, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub Awaiting requested review from pSub

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @bjornfor