Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md: bump backport example #97600

Closed
wants to merge 1 commit into from
Closed

CONTRIBUTING.md: bump backport example #97600

wants to merge 1 commit into from

Conversation

roberth
Copy link
Member

@roberth roberth commented Sep 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Usually we do this when it's released, but I guess it makes more sense to do it when it's branched https://github.com/NixOS/nixpkgs/pull/97141/files. An alternative is to make the example non literal

@jonringer
Copy link
Contributor

20.09 hasn't been official released, and ZHF period is a little be more liberal in what can be backported. We should probably mention that important backports should target both branches. And according to the nixos manual, 20.03 isn't officially deprecated until october

@roberth
Copy link
Member Author

roberth commented Dec 15, 2020

Already done in some other commit.

@roberth roberth closed this Dec 15, 2020
@SuperSandro2000 SuperSandro2000 deleted the contributing-bump-examples branch February 2, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roberth @worldofpeace @jonringer @ryantm