RDS: Support VPC #113
Merged
RDS: Support VPC #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
force-pushed
the
rds-subnet-groups
branch
from
af463f9
to
46a090e
Compare
grahamc
force-pushed
the
rds-subnet-groups
branch
from
46a090e
to
2a86846
Compare
There was a problem hiding this comment.
Looks good to me! I'll check my PR to see if there's something that I have added. The only worry I have is regarding EC2-VPC (new) vs EC2-Classic (legacy) accounts. We had this issue with my PR, it's difficult to test if you don't have both type of accounts :/.
grahamc
force-pushed
the
rds-subnet-groups
branch
from
2a86846
to
eea168e
Compare
andir
force-pushed
the
rds-subnet-groups
branch
from
b88e3b5
to
a6c8d9c
Compare
|
This introduced a regression: networks on old-style security groups now have an error unless they specify an empty list of vpc security groups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create resources for subnet groups to allow RDS instances to be spawned in a VPC. Closes #57, #13, #6.
cc @RaitoBezarius -- I didn't think to look for your PR before I wrote this (sorry :() but also that one is pre-py3, etc.