Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i3-resurrect: init at 1.4.3 #97480

Closed
wants to merge 2 commits into from
Closed

i3-resurrect: init at 1.4.3 #97480

wants to merge 2 commits into from

Conversation

nullscm
Copy link

@nullscm nullscm commented Sep 8, 2020 •
edited

Motivation for this change

Missing Package i needed for my workflow

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@magnetophon
Copy link
Member

I tried to build this, but didn't get any binaries, afaik:

nixpkgs-review pr 97480
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/97480/head:refs/nixpkgs-review/1
remote: Enumerating objects: 7, done.
remote: Counting objects: 100% (7/7), done.
remote: Total 7 (delta 5), reused 7 (delta 5), pack-reused 0
Unpacking objects: 100% (7/7), 1018 bytes | 127.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   83162ab3b97..23370afcedc  master     -> refs/nixpkgs-review/0
$ git worktree add /home/bart/.cache/nixpkgs-review/pr-97480-1/nixpkgs 23370afcedc46f63ea0dc7328bcb1f40d78887bf
Preparing worktree (detached HEAD 23370afcedc)
Updating files: 100% (22750/22750), done.
HEAD is now at 23370afcedc curlie: 1.3.1 -> 1.5.4
$ nix-env -f /home/bart/.cache/nixpkgs-review/pr-97480-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 34c180c16785698e7add57a7b6197f99bea9c8f8
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/bart/.cache/nixpkgs-review/pr-97480-1/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing changed
https://github.com/NixOS/nixpkgs/pull/97480
$ nix-shell /home/bart/.cache/nixpkgs-review/pr-97480-1/shell.nix

i3-resurrect save
i3-resurrect: command not found

Am I doing something wrong?

@magnetophon
Copy link
Member

@vldn-dev I found at least 2 issues:

  • You need to add yourself to nixpkgs/maintainers/maintainer-list.nix.
  • You need to add the following line to nixpkgs/pkgs/top-level/all-packages.nix
    i3-resurrect = python3Packages.callPackage ../applications/window-managers/i3/i3-resurrect.nix { };
    I suggest to add it after i3-layout-manager = callPackage ../applications/window-managers/i3/layout-manager.nix { };

The reason I said "at least" is because the program is only partially working for me, but that might be either pebcac or an upstream issue.

magnetophon added a commit to magnetophon/nixpkgs that referenced this pull request Nov 19, 2020
@magnetophon
i3-resurrect: init at 1.4.3
dccf53e 
corrected from NixOS#97480 by @vldn-dev
@magnetophon magnetophon mentioned this pull request Nov 19, 2020
Merged
10 tasks
SuperSandro2000
SuperSandro2000 reviewed Nov 27, 2020
View reviewed changes
pkgs/applications/window-managers/i3/i3-resurrect.nix
};

propagatedBuildInputs = [ click psutil xprop natsort i3ipc xdotool importlib-metadata ];
doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you disable the tests?

SuperSandro2000
SuperSandro2000 reviewed Nov 27, 2020
View reviewed changes
pkgs/applications/window-managers/i3/i3-resurrect.nix Outdated
Comment on lines 22 to 23
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

SuperSandro2000
SuperSandro2000 requested changes Nov 27, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also resolve the other review comment. Marking it a draft.

@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 27, 2020 18:22
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 97480 run on x86_64-linux 1

magnetophon added a commit to magnetophon/nixpkgs that referenced this pull request Dec 16, 2020
@magnetophon
i3-resurrect: init at 1.4.3
9ce1ec8 
corrected from NixOS#97480 by @vldn-dev
@joovisbv @SuperSandro2000
Update pkgs/applications/window-managers/i3/i3-resurrect.nix
0fb5623 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@magnetophon
Copy link
Member

In the meantime this one got merged:
#104324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nullscm @magnetophon @SuperSandro2000 @joovisbv