Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noisetorch: 0.5.2-beta -> 0.8.2 #97530

Merged
merged 3 commits into from Nov 24, 2020
Merged

noisetorch: 0.5.2-beta -> 0.8.2 #97530

merged 3 commits into from Nov 24, 2020

Conversation

reedrw
Copy link
Contributor

@reedrw reedrw commented Sep 9, 2020 •
edited

Motivation for this change

noisetorch has added a more complete command line implementation, which is useful for running the software as a systemd service among other things.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and PanAeon September 9, 2020 12:01
@PanAeon
Copy link
Contributor

PanAeon commented Sep 9, 2020

@reedrw do you thing it is worth while to add this as a systemd service in nixos?

@reedrw
Copy link
Contributor Author

reedrw commented Sep 9, 2020 •
edited

I think it would be pretty cool if I could have something like

{
  services.noisetorch = {
    enable = true;
    device = "alsa_output.<whatever>";
  };
}

in my configuration.nix. But I don't really know a lot about writing NixOS modules to do it myself (nor am I really that worried about it not being there).

@PanAeon
Copy link
Contributor

PanAeon commented Sep 9, 2020

yeah, maybe I'll add a ticket for this, after all it's a little bit of convenience. Adding a user service is not a problem, but I think I'll have to create a Virtualbox VM in order to test it...

@reedrw reedrw changed the title noisetorch: 0.5.2-beta -> 0.7.2-beta noisetorch: 0.5.2-beta -> 0.8.0-beta Nov 12, 2020
@reedrw
Copy link
Contributor Author

reedrw commented Nov 12, 2020

I forgot about this until my NUR bot update of it failed. The config.go patch is no longer necessary as the updater is no longer compiled by default.

@ofborg ofborg bot requested a review from PanAeon November 12, 2020 18:29
@reedrw
Copy link
Contributor Author

reedrw commented Nov 12, 2020

And naturally a new release comes out minutes after I update this PR

@reedrw reedrw changed the title noisetorch: 0.5.2-beta -> 0.8.0-beta noisetorch: 0.5.2-beta -> 0.8.2 Nov 12, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 97530 run on x86_64-linux 1

1 package built:
  • noisetorch

@SuperSandro2000 SuperSandro2000 merged commit 6f29643 into NixOS:master Nov 24, 2020
@reedrw reedrw deleted the noisetorch-072 branch November 27, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@PanAeon PanAeon Awaiting requested review from PanAeon

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reedrw @PanAeon @SuperSandro2000 @Janik-Haag