Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gambatte: add alsa dependency, 2016-05-03 -> 2020-03-14 #97507

Merged
merged 1 commit into from Sep 15, 2020
Merged

gambatte: add alsa dependency, 2016-05-03 -> 2020-03-14 #97507

merged 1 commit into from Sep 15, 2020

Conversation

jonascarpay
Copy link
Contributor

Add alsaLib dependency to gambatte to fix failing build.
Also bumps the version, although this is not necessary to fix the build.

Motivation for this change

Fixing the build in preparation for backporting to ZHF 20.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonascarpay jonascarpay changed the title gambatte: add alsa dependency and version bump gambatte: add alsa dependency, 2016-05-03 -> 2020-03-14 Sep 9, 2020
@ofborg ofborg bot requested a review from dezgeg September 9, 2020 06:55
@TethysSvensson TethysSvensson mentioned this pull request Sep 13, 2020
Closed
10 tasks
@matthewbauer matthewbauer merged commit a4ad9e7 into NixOS:master Sep 15, 2020
@jonascarpay jonascarpay deleted the gambatte-alsa-fix branch September 15, 2020 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonascarpay @matthewbauer