Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpdscribble: 0.22 -> 0.23 #97541

Merged
merged 2 commits into from Sep 10, 2020
Merged

mpdscribble: 0.22 -> 0.23 #97541

merged 2 commits into from Sep 10, 2020

Conversation

Sohalt
Copy link
Contributor

@Sohalt Sohalt commented Sep 9, 2020

Motivation for this change

Upstream update

cc @matthiasbeyer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

matthiasbeyer
matthiasbeyer approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@matthiasbeyer
Copy link
Contributor

Would you care to take maintainership for this package?

@Sohalt
Copy link
Contributor Author

Sohalt commented Sep 10, 2020

Would you care to take maintainership for this package?

I'm fine with taking maintainership. I've made the corresponding changes.

@ajs124 ajs124 merged commit d5d6bd7 into NixOS:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sohalt @matthiasbeyer @ajs124