Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildRustPackage: support setting test-threads #97603

Merged
merged 4 commits into from Sep 25, 2020
Merged

buildRustPackage: support setting test-threads #97603

merged 4 commits into from Sep 25, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Sep 9, 2020 •
edited

Motivation for this change

Setting --test-threads=$NIX_BUILD_CORES breaks packages that require --test-threads=1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq mentioned this pull request Sep 9, 2020
Merged
10 tasks
@ofborg ofborg bot added the 6.topic: rust label Sep 10, 2020
@ofborg ofborg bot requested review from masaeedu and fgaz September 10, 2020 00:15
@ofborg ofborg bot requested a review from masaeedu September 10, 2020 07:45
@zowoq zowoq marked this pull request as ready for review September 10, 2020 10:24
@zowoq zowoq requested a review from andir as a code owner September 10, 2020 10:24
@zowoq zowoq requested review from marsam and Mic92 September 10, 2020 10:24
@zowoq zowoq marked this pull request as draft September 13, 2020 20:48
@zowoq zowoq marked this pull request as ready for review September 23, 2020 11:22
@Mic92 Mic92 mentioned this pull request Sep 25, 2020
Merged
@Mic92 Mic92 merged commit a2960ac into NixOS:master Sep 25, 2020
@zowoq zowoq deleted the rust-test-threads branch September 25, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@fgaz fgaz Awaiting requested review from fgaz

@masaeedu masaeedu Awaiting requested review from masaeedu

@andir andir Awaiting requested review from andir

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: rust 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @Mic92 @masaeedu