Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.mayavi: 4.7.1 -> 4.7.2; vtk -> vtk_9 #97602

Closed
wants to merge 1 commit into from
Closed

python3Packages.mayavi: 4.7.1 -> 4.7.2; vtk -> vtk_9 #97602

wants to merge 1 commit into from

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Sep 9, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from knedlsepp September 10, 2020 00:42
drewrisinger
drewrisinger approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review: Built everything through vtk_9, but that was taking too long so I quit.

@bcdarwin
python3Packages.mayavi: 4.7.1 -> 4.7.2; vtk -> vtk_9
44ab312 
 - also removed python3Packages.vtk_{7,8} since nothing uses these and they're expensive to build
@bcdarwin
Copy link
Member Author

I've rebased onto master and resolved merge conflicts due to VTK expression refactoring. I've left the disabledIf isPy2k for now.

I also removed vtk_7 and vtk_8 from the Python package set since nothing in the tree uses them and they're expensive to build.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 97602 run on x86_64-linux 1

5 packages built:
  • python37Packages.mayavi
  • python37Packages.vtk
  • python38Packages.mayavi
  • python38Packages.vtk
  • python39Packages.vtk

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 19, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 97602 run on x86_64-darwin 1

2 packages failed to build and are new build failures:
  • python37Packages.mayavi: log was empty
  • python38Packages.mayavi: log was empty
3 packages built:
  • python37Packages.vtk
  • python38Packages.vtk
  • python39Packages.vtk

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 97602 run on x86_64-darwin 1

2 packages failed to build and are new build failures:
  • python37Packages.mayavi: log was empty
  • python38Packages.mayavi: log was empty
3 packages built:
  • python37Packages.vtk
  • python38Packages.vtk
  • python39Packages.vtk
error: --- Error ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- nixbuilder for '/nix/store/4wkaww74i5d5czvk8dcqqd5d0ir32ryy-python3.7-envisage-4.9.2.drv' failed with exit code 1; last 10 log lines:                                                            Ran 229 tests in 1.446s                                                                                                                                                                                                                                                                                                                                                                 FAILED (failures=19, errors=1, skipped=6)                                                                                                                                                   Error in atexit._run_exitfuncs:                                                                                                                                                             Traceback (most recent call last):                                                                                                                                                            File "/private/tmp/nix-build-python3.7-envisage-4.9.2.drv-0/envisage-4.9.2/envisage/plugins/ipython_kernel/kernelapp.py", line 198, in close                                                  self.close_shell()                                                                                                                                                                        File "/private/tmp/nix-build-python3.7-envisage-4.9.2.drv-0/envisage-4.9.2/envisage/plugins/ipython_kernel/kernelapp.py", line 215, in close_shell                                            shell = self.kernel.shell                                                                                                                                                               AttributeError: 'NoneType' object has no attribute 'shell'                                                                                                                                error: --- Error ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix1 dependencies of derivation '/nix/store/8k591n422x7f9h5jvddywsrgak6sd1g3-python3.7-mayavi-4.7.2.drv' failed to build                                                                       error: --- Error ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- nixbuilder for '/nix/store/6sx91w7mhxfxph4mp5ygbmq8w3n7qzvd-python3.8-envisage-4.9.2.drv' failed with exit code 1; last 10 log lines:                                                            Ran 229 tests in 1.434s                                                                                                                                                                                                                                                                                                                                                                 FAILED (failures=19, errors=1, skipped=6)                                                                                                                                                   Error in atexit._run_exitfuncs:                                                                                                                                                             Traceback (most recent call last):                                                                                                                                                            File "/private/tmp/nix-build-python3.8-envisage-4.9.2.drv-0/envisage-4.9.2/envisage/plugins/ipython_kernel/kernelapp.py", line 198, in close                                                  self.close_shell()                                                                                                                                                                        File "/private/tmp/nix-build-python3.8-envisage-4.9.2.drv-0/envisage-4.9.2/envisage/plugins/ipython_kernel/kernelapp.py", line 215, in close_shell                                            shell = self.kernel.shell                                                                                                                                                               AttributeError: 'NoneType' object has no attribute 'shell'                                                                                                                                error: --- Error ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix1 dependencies of derivation '/nix/store/zbxsz8garalqjhhm355nwdx6pnfbrsjl-python3.8-mayavi-4.7.2.drv' failed to build                                                                       error: --- Error ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix2 dependencies of derivation '/nix/store/xqmlhm3h4wq1d57bb6w9q7br097y2fad-env.drv' failed to build

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@bcdarwin
Copy link
Member Author

bcdarwin commented Aug 7, 2021

Obsoleted by #133056.

@bcdarwin bcdarwin closed this Aug 7, 2021
@bcdarwin bcdarwin deleted the update-mayavi branch August 7, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcdarwin @SuperSandro2000 @FRidh @drewrisinger