Skip to content

reason: 3.6.0 → 3.6.2 #97502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2020
Merged

reason: 3.6.0 → 3.6.2 #97502

merged 1 commit into from
Sep 12, 2020
+3 −3

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 9, 2020

Motivation for this change

Compatibility with OCaml 4.11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc/ maintainer @volth

Sorry, something went wrong.

@vbgl
reason: 3.6.0 → 3.6.2

Verified

This commit was signed with the committer’s verified signature. The key has expired.
vbgl Vincent Laporte
GPG key ID: EBD582ADDDB1F81F
Expired
Verified
Learn about vigilant mode
8a14e9e
@vbgl vbgl added 8.has: package (update) This PR updates a package to a newer version 6.topic: ocaml labels Sep 9, 2020
@ofborg ofborg bot requested a review from volth September 9, 2020 04:40
@vbgl
Copy link
Contributor Author

vbgl commented Sep 9, 2020

@GrahamcOfBorg build ocamlPackages.graphql_ppx

bcdarwin
bcdarwin approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit looks fine, builds on NixOS, binaries appear to work.

@vbgl vbgl merged commit d3e701f into NixOS:master Sep 12, 2020
@vbgl vbgl deleted the reason-3.6.2 branch September 12, 2020 19:30
@vbgl
Copy link
Contributor Author

vbgl commented Sep 12, 2020

Merged into 20.09 as 8ee39f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @bcdarwin