wasmer: enable cranelift backend #97518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrainerson
force-pushed
the
wasmer-backend
branch
from
ffe3d34
to
97b40ed
Compare
simonrainerson
force-pushed
the
wasmer-backend
branch
from
97b40ed
to
39be683
Compare
Since wasmer 0.17 no backends are enabled by default. Backends are now detected using the [makefile](https://github.com/wasmerio/wasmer/blob/master/Makefile). This change enables cranelift as this used to be the old default. At least one backend is needed for the `run` subcommand to work. If we want to replicate the actual logic in the makefile, we would probably want to enable the singlepass and llvm backend as well. However enabling llvm backend introduces a dependency on openssl, so we opted for replicating the old default behavior.
simonrainerson
force-pushed
the
wasmer-backend
branch
from
39be683
to
5cf2869
Compare
|
Result of 1 package built:
|
|
Result of 1 package built:
|
SuperSandro2000
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since wasmer 0.17 no backends are enabled by default. Backends are now detected
using the makefile.
This change enables cranelift as this used to be the old default. At
least one backend is needed for the
runsubcommand to work. If we wantto replicate the actual logic in the makefile, we would probably want to
enable the singlepass and llvm backend as well. However enabling llvm
backend introduces a dependency on openssl, so we opted for replicating
the old default behavior.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)