Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.executor: 21.3 -> 23.1, fix tests #97494

Merged
merged 1 commit into from
Sep 10, 2020
Merged

python3Packages.executor: 21.3 -> 23.1, fix tests #97494

merged 1 commit into from
Sep 10, 2020
+13 −9

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 9, 2020 •
edited
Loading

Motivation for this change

ZHF: #97479

@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/97494
6 packages built:
executor python37Packages.executor python37Packages.rotate-backups python37Packages.update-dotdee rotate-backups update-dotdee

Sorry, something went wrong.

@jonringer
python3Packages.executor: 21.3 -> 23.1, fix tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ae0b2f5
@jonringer jonringer requested a review from FRidh as a code owner September 9, 2020 01:15
@ofborg ofborg bot requested a review from eyJhb September 9, 2020 01:41
@jonringer jonringer merged commit 5916b96 into NixOS:master Sep 10, 2020
@jonringer jonringer deleted the fix-executor branch September 10, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@FRidh FRidh

@eyJhb eyJhb

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @worldofpeace