Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-design: Implement navbar active state #521

Merged
merged 6 commits into from Sep 14, 2020
Merged

re-design: Implement navbar active state #521

merged 6 commits into from Sep 14, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Sep 9, 2020 •
edited

Navbar active state

It was missing from its previous implementation.

This adds a bit of machinery in the layout where we are templating the links for the header.

Navbar search

Simply done for now.

@samueldr samueldr added the design About the design refresh work label Sep 9, 2020
@samueldr samueldr force-pushed the feature/2020-r/navigation-fixups branch from 76b5fe1 to d4d8bf5 Compare September 10, 2020 19:26
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f5a7eb46b52eb0fe2223310--nixos-homepage.netlify.app

davidak
davidak approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works to show the active page

Screenshot from 2020-09-10 21-58-20

search also works

only thing not working in the manu is the Install Nix button (not part of this pr, just want to mention it)

@samueldr samueldr merged commit 1186689 into feature/2020-redesign Sep 14, 2020
@samueldr samueldr deleted the feature/2020-r/navigation-fixups branch September 14, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
design About the design refresh work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samueldr @davidak