Skip to content

electron-cash: 4.0.14 -> 4.1.0 #97607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2020
Merged

electron-cash: 4.0.14 -> 4.1.0 #97607

merged 1 commit into from
Sep 10, 2020
+14 −6

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Sep 9, 2020 •
edited
Loading

Motivation for this change

Broken build #97479

I also needed to add a patch because of a broken test

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@nyanloutre
electron-cash: 4.0.14 -> 4.1.0

Verified

This commit was signed with the committer’s verified signature. The key has expired.
nyanloutre Paul TREHIOU
GPG key ID: 194A92D1103ACB2A
Expired
Verified
Learn about vigilant mode
d3958aa
@ofborg ofborg bot requested a review from Lassulus September 10, 2020 01:39
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 10, 2020
@Lassulus Lassulus merged commit 0ce8cf8 into NixOS:master Sep 10, 2020
@nyanloutre nyanloutre deleted the master branch September 10, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nyanloutre @Lassulus