Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxpanel: fix build by switching to gdk-pixbuf-xlib #97608

Merged
merged 1 commit into from Sep 10, 2020
Merged

lxpanel: fix build by switching to gdk-pixbuf-xlib #97608

merged 1 commit into from Sep 10, 2020

Conversation

ryneeverett
Copy link
Contributor

Motivation for this change

The build has been broken since gdk-pixbuf-xlib was broken out into a
separate package in #88086.

For some reason if I just add gdk-pixbuf-xlib.dev the headers don't make it
into CFLAGS.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need gdk-pixbuf and gdk-pixbuf-xlib https://github.com/lxde/lxpanel/blob/69e1bdbfba252b03a699321dfb312c52a8bd44fa/plugins/launchtaskbar.c#L70.
You didn't notice this becasue xlib propagates gdk-pixbuf. Can you add it back to buildInputs?

@ryneeverett
lxpanel: fix build by switching to gdk-pixbuf-xlib
5b49a74 
The build has been broken since gdk-pixbuf-xlib was broken out into a
separate package in NixOS#88086.

For some reason if I just add gdk-pixbuf-xlib.dev the headers don't make it
into CFLAGS.
@worldofpeace worldofpeace merged commit 2e7fcfd into NixOS:master Sep 10, 2020
@worldofpeace
Copy link
Contributor

Thanks @ryneeverett. Awaiting backport PR

@ryneeverett ryneeverett mentioned this pull request Sep 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryneeverett @worldofpeace