zict: disable python 2 and 3.5. #97605
Conversation
ofborg
bot
added
6.topic: python
8.has: clean-up
10.rebuild-darwin: 0
| @@ -35,11 +36,14 @@ buildPythonPackage rec { | |||
| sha256 = "469e505fd7ce75f600188bdb69a95641899d5b372f74246c8f308376b6929e9c"; | |||
| }; | |||
|
|
|||
| # zict dependency is now python 3.6+ only | |||
| disabled = !(pythonAtLeast "3.6"); | |||
There was a problem hiding this comment.
| disabled = !(pythonAtLeast "3.6"); | |
| disabled = pythonOlder "3.6"; |
| @@ -38,6 +39,9 @@ buildPythonPackage rec { | |||
| requests | |||
| ]; | |||
|
|
|||
| # zict dependency is now python 3.6+ only | |||
| disabled = !(pythonAtLeast "3.6"); | |||
There was a problem hiding this comment.
| disabled = !(pythonAtLeast "3.6"); | |
| disabled = pythonOlder "3.6"; |
| @@ -38,6 +39,9 @@ buildPythonPackage rec { | |||
| requests | |||
| ]; | |||
|
|
|||
| # zict dependency is now python 3.6+ only | |||
There was a problem hiding this comment.
Wording is a little confusing, implies that it would support e.g. py3.5 if not for zict. Maybe just say is python 3.6+ only, though that's implied by disabled=pythonOlder 3.6
| @@ -38,6 +39,9 @@ buildPythonPackage rec { | |||
| requests | |||
| ]; | |||
|
|
|||
| # zict dependency is now python 3.6+ only | |||
There was a problem hiding this comment.
then dict should be marked accordingly, I wouldn't mark this as disabled just because a dependency doesn't work on it.
One example would be if someone override zict, streamz should still work.
There was a problem hiding this comment.
Thanks for the review! To clarify: You are saying that marking zict as pythonOlder "3.6"; is enough?
There was a problem hiding this comment.
That's enough for me. Looking at the distributed and streamz dependencies on PyPi, those list the required python as >=3.6, so marking zict, streamz, distributed as disabled = pythonOlder "3.6"; without comment seems good to me.
There was a problem hiding this comment.
Ok thanks - updated accordingly.
|
Can you break this into 3 commits, one per file? You can do this with PR & commit titles should also be named something like |
Part of ZHF in #97479
Motivation for this change
Zero hydra failures
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)