Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 56708c3bf301
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c97fcc3fe088
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 8, 2020

  1. nixos/openvpn: path now requires conversion to a string 

    Following changes in #91092 the `path` attribute is now a list
instead of being a string. This resulted resulted in the following evaluation error:

"cannot coerce a list to a string, at [...]/nixos/modules/services/networking/openvpn.nix:16:18"

so we now need to convert it to the right type ourselves.

Closes #97360.
    @pbogdan
    pbogdan committed Sep 8, 2020
    Copy the full SHA
    cb14135 View commit details

Commits on Sep 9, 2020

  1. Merge pull request #97438 from pbogdan/openvpn-path 

    nixos/openvpn: path now requires conversion to a string
    @ajs124
    ajs124 authored Sep 9, 2020
    Copy the full SHA
    c97fcc3 View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 nixos/modules/services/networking/openvpn.nix
2 changes: 1 addition & 1 deletion nixos/modules/services/networking/openvpn.nix
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ let
makeOpenVPNJob = cfg: name:
let

path = (getAttr "openvpn-${name}" config.systemd.services).path;
path = makeBinPath (getAttr "openvpn-${name}" config.systemd.services).path;

upScript = ''
#! /bin/sh