Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bmap-tools: Don't test, as tests fail on hydra #97510

Merged
merged 1 commit into from
Sep 9, 2020
Merged

bmap-tools: Don't test, as tests fail on hydra #97510

merged 1 commit into from
Sep 9, 2020
+3 −0

Conversation

doronbehar
Copy link
Contributor

e.g: https://hydra.nixos.org/build/126796743/nixlog/1/tail

Interestingly, this was supposed to be fixed by upstream at intel/bmap-tools#16, and 3.4 which we use is supposed to include that patch.

cc @NixOS/nixos-release-managers

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot requested a review from dezgeg September 9, 2020 07:23
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 9, 2020
@worldofpeace worldofpeace merged commit 88f0b99 into NixOS:master Sep 9, 2020
@worldofpeace
Copy link
Contributor

thx ✨

@doronbehar doronbehar deleted the ZHF/bmap-tools branch March 2, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dezgeg dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @worldofpeace