Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cht-sh: unstable-2019-08-06 -> unstable-2020-08-06 #97539

Merged
merged 1 commit into from Sep 9, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Sep 9, 2020

Motivation for this change

chubin/cheat.sh@f507ba5...9f99bec

@evanjs evanjs requested a review from fgaz September 9, 2020 13:08
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the package attribute in the commit message (cht-sh), not the pname

@evanjs
Copy link
Member Author

evanjs commented Sep 9, 2020

Please use the package attribute in the commit message (cht-sh), not the pname

I will make sure I also do this going forward. Thanks!

@evanjs evanjs changed the title cht.sh: unstable-2019-08-06 -> unstable-2020-08-06 cht-sh: unstable-2019-08-06 -> unstable-2020-08-06 Sep 9, 2020
@fgaz
Copy link
Member

fgaz commented Sep 9, 2020

Actually CONTRIBUTING.md is ambiguous about it, but ofborg will only build the package if the commit mentions the attr

Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit fa0ed8d into NixOS:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants