Skip to content

cht-sh: unstable-2019-08-06 -> unstable-2020-08-06 #97539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2020
Merged

cht-sh: unstable-2019-08-06 -> unstable-2020-08-06 #97539

merged 1 commit into from
Sep 9, 2020
+3 −3

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Sep 9, 2020

Motivation for this change

chubin/cheat.sh@f507ba5...9f99bec

@evanjs evanjs requested a review from fgaz September 9, 2020 13:08
@evanjs
cht.sh: unstable-2019-08-06 -> unstable-2020-08-06

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2
Verified
Learn about vigilant mode
6655109
@evanjs evanjs force-pushed the cht.sh/unstable-2020-08-06 branch from 88003f5 to 6655109 Compare September 9, 2020 13:20
fgaz
fgaz requested changes Sep 9, 2020
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the package attribute in the commit message (cht-sh), not the pname

@ofborg ofborg bot requested a review from fgaz September 9, 2020 14:07
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 9, 2020
@evanjs
Copy link
Member Author

evanjs commented Sep 9, 2020 •
edited
Loading

Please use the package attribute in the commit message (cht-sh), not the pname

I will make sure I also do this going forward. Thanks!

@evanjs evanjs changed the title cht.sh: unstable-2019-08-06 -> unstable-2020-08-06 cht-sh: unstable-2019-08-06 -> unstable-2020-08-06 Sep 9, 2020
@fgaz
Copy link
Member

fgaz commented Sep 9, 2020

Actually CONTRIBUTING.md is ambiguous about it, but ofborg will only build the package if the commit mentions the attr

fgaz
fgaz approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evanjs evanjs requested a review from jonringer September 9, 2020 14:21
@worldofpeace worldofpeace merged commit fa0ed8d into NixOS:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgaz fgaz

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanjs @fgaz @worldofpeace