New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-design: MVP contents for the last footer section #520
Merged
samueldr
merged 22 commits into
feature/2020-redesign
from
feature/2020-r/footer-details
Sep 14, 2020
Merged
re-design: MVP contents for the last footer section #520
samueldr
merged 22 commits into
feature/2020-redesign
from
feature/2020-r/footer-details
Sep 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pre-nixcon survey banner
pup formatted the html which produced some white space.
Integrate nix.dev tutorials as a flake
samueldr
changed the title
MVP contents for the last footer section
re-design: MVP contents for the last footer section
Sep 9, 2020
Fix broken netlify deployment
samueldr
force-pushed
the
feature/2020-r/footer-details
branch
from
September 10, 2020 19:25
29740d1
to
5345058
Compare
davidak
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i agree that this is an improvement over the TODO
i'm not sure if we need such marketing/sales tricks in general, but let's try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better than the "TODO" previously found there.
The mockups have this widget thing (right column):
I, frankly, don't know how we can do anything useful with the suggestion of a square radio button (ew) and common buttons. It adds machinery that we're probably better off not having to deal with for this to work as expected.
As always, this is open to further improvements. Right now, we at least have the same spiritual use case (link to tool-specific sections).