Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] verilog: unstable-2019-08-01 -> unstable-2020-08-24 #97567

Merged
merged 1 commit into from Sep 9, 2020
Merged

[20.09] verilog: unstable-2019-08-01 -> unstable-2020-08-24 #97567

merged 1 commit into from Sep 9, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Sep 9, 2020

The build would previously fail due to a change in bison's behavior (see
steveicarus/iverilog@5b699c1
for more information). Updating to a more recent version fixes this
issue.

(cherry picked from commit 339f624)

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NixOS/nixos-release-managers

@cole-h
verilog: unstable-2019-08-01 -> unstable-2020-08-24
ea10097 
The build would previously fail due to a change in bison's behavior (see
steveicarus/iverilog@5b699c1
for more information). Updating to a more recent version fixes this
issue.

(cherry picked from commit 339f624)
@worldofpeace worldofpeace merged commit 1d6f202 into NixOS:release-20.09 Sep 9, 2020
@worldofpeace
Copy link
Contributor

thx ✨

@cole-h cole-h deleted the release-20.09 branch September 9, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @worldofpeace