Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

traefik: 2.2.8 -> 2.2.11, pin to go 1.14 #97568

Merged
merged 3 commits into from Sep 11, 2020
Merged

traefik: 2.2.8 -> 2.2.11, pin to go 1.14 #97568

merged 3 commits into from Sep 11, 2020

Conversation

amaxine
Copy link
Member

@amaxine amaxine commented Sep 9, 2020

Motivation for this change

Version bump. Pinning to 1.14 based on traefik/traefik#7234 and since the x.509 changes in 1.15 would result in probably unhappy changes in behaviour for anyone running this in production.

Also fixes passing build flags so that traefik no longer reports its version as dev.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@endocrimes
Copy link
Member

Result of nixpkgs-review pr 97568 1

1 package built:
  • traefik

@ofborg ofborg bot requested review from kalbasit and vdemeester September 9, 2020 18:14
kalbasit
kalbasit approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, otherwise LGTM

pkgs/top-level/all-packages.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit September 10, 2020 08:50
@marsam marsam merged commit 2511a36 into NixOS:master Sep 11, 2020
@amaxine amaxine deleted the traefik_2.2.11 branch September 11, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@zowoq zowoq zowoq approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amaxine @endocrimes @kalbasit @zowoq @marsam