Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] cantata: add perl for dynamic playlists #97483

Merged
merged 1 commit into from Sep 8, 2020
Merged

[20.09] cantata: add perl for dynamic playlists #97483

merged 1 commit into from Sep 8, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Sep 8, 2020 •
edited

Cantata wants to check if perl is available at runtime, but we already patch the
script shebangs, making it unnecessary to be available at runtime --
thus, patch out this check.

(cherry picked from commit fca7cc5)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @worldofpeace

@cole-h
cantata: add perl for dynamic playlists
524369c 
Cantata wants to check if perl is available at runtime, but we already patch the
script shebangs, making it unnecessary to be available at runtime --
thus, patch out this check.

(cherry picked from commit fca7cc5)
@cole-h cole-h mentioned this pull request Sep 8, 2020
Merged
10 tasks
@worldofpeace worldofpeace merged commit e83908c into NixOS:release-20.09 Sep 8, 2020
@worldofpeace
Copy link
Contributor

Thanks @cole-h ✨

@cole-h cole-h deleted the release-20.09 branch September 8, 2020 23:56
@cole-h cole-h restored the release-20.09 branch September 9, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @worldofpeace