Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlton: fix build #97576

Merged
merged 2 commits into from Sep 9, 2020
Merged

mlton: fix build #97576

merged 2 commits into from Sep 9, 2020

Conversation

gebner
Copy link
Member

@gebner gebner commented Sep 9, 2020

Motivation for this change

Failed to build because which is missing.
https://hydra.nixos.org/build/126588345/nixlog/1

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner gebner added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 9, 2020
@worldofpeace worldofpeace merged commit 63e1162 into NixOS:master Sep 9, 2020
@worldofpeace
Copy link
Contributor

Thanks @gebner ✨ You know what do next 😬

@gebner
Copy link
Member Author

gebner commented Sep 9, 2020

Backported as 3a8c2b7 and a824b76.

@gebner gebner mentioned this pull request Sep 10, 2020
Merged
10 tasks
@FliegendeWurst FliegendeWurst removed the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gebner @worldofpeace @FliegendeWurst