Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-providers: add version to patchGoModVendor providers #97590

Merged
merged 1 commit into from Sep 27, 2020
Merged

terraform-providers: add version to patchGoModVendor providers #97590

merged 1 commit into from Sep 27, 2020

Conversation

Myhlamaeus
Copy link
Contributor

Motivation for this change

Add version to binaries produced via patchGoModVendor to allow run-time provider
version validation by terraform.

This was initially introduced in 4e63119 (terraform: add the version component to terraform provider paths (#34497), 2018-02-06)
but broken in 3e5149a (terraform-providers: fix the google and google-beta providers, 2020-03-24)
for terraform-providers.google and terraform-providers.google-beta, and in 20f55a9 (terraform-providers.ibm: move to update-all script, 2020-04-26)
for terraform-providers.ibm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Myhlamaeus
terraform-providers: add version to patchGoModVendor providers
5d309b6 
Add version to binaries produced via patchGoModVendor to allow run-time provider
version validation by terraform.

This was initially introduced in 4e63119 (terraform: add the version component to terraform provider paths (NixOS#34497), 2018-02-06)
but broken in 3e5149a (terraform-providers: fix the google and google-beta providers, 2020-03-24)
for terraform-providers.google and terraform-providers.google-beta, and in 20f55a9 (terraform-providers.ibm: move to update-all script, 2020-04-26)
for terraform-providers.ibm.
@zimbatm zimbatm merged commit 94d2aeb into NixOS:master Sep 27, 2020
@zimbatm
Copy link
Member

zimbatm commented Sep 27, 2020

Result of nixpkgs-review pr 97590 1

149 packages built:
  • terraform-full
  • terraform-providers.aci
  • terraform-providers.acme
  • terraform-providers.akamai
  • terraform-providers.alicloud
  • terraform-providers.archive
  • terraform-providers.arukas
  • terraform-providers.auth0
  • terraform-providers.avi
  • terraform-providers.aviatrix
  • terraform-providers.aws
  • terraform-providers.azuread
  • terraform-providers.azurerm
  • terraform-providers.azurestack
  • terraform-providers.baiducloud
  • terraform-providers.bigip
  • terraform-providers.bitbucket
  • terraform-providers.brightbox
  • terraform-providers.checkpoint
  • terraform-providers.chef
  • terraform-providers.cherryservers
  • terraform-providers.ciscoasa
  • terraform-providers.clc
  • terraform-providers.cloudflare
  • terraform-providers.cloudinit
  • terraform-providers.cloudscale
  • terraform-providers.cloudstack
  • terraform-providers.cobbler
  • terraform-providers.cohesity
  • terraform-providers.constellix
  • terraform-providers.consul
  • terraform-providers.ct
  • terraform-providers.datadog
  • terraform-providers.digitalocean
  • terraform-providers.dme
  • terraform-providers.dns
  • terraform-providers.dnsimple
  • terraform-providers.docker
  • terraform-providers.dome9
  • terraform-providers.dyn
  • terraform-providers.exoscale
  • terraform-providers.external
  • terraform-providers.fastly
  • terraform-providers.flexibleengine
  • terraform-providers.fortios
  • terraform-providers.genymotion
  • terraform-providers.github
  • terraform-providers.gitlab
  • terraform-providers.google
  • terraform-providers.google-beta
  • terraform-providers.grafana
  • terraform-providers.gridscale
  • terraform-providers.hcloud
  • terraform-providers.hedvig
  • terraform-providers.helm
  • terraform-providers.heroku
  • terraform-providers.http
  • terraform-providers.huaweicloud
  • terraform-providers.huaweicloudstack
  • terraform-providers.ibm
  • terraform-providers.icinga2
  • terraform-providers.ignition
  • terraform-providers.incapsula
  • terraform-providers.influxdb
  • terraform-providers.infoblox
  • terraform-providers.jdcloud
  • terraform-providers.ksyun
  • terraform-providers.kubernetes
  • terraform-providers.kubernetes-alpha
  • terraform-providers.launchdarkly
  • terraform-providers.librato
  • terraform-providers.linode
  • terraform-providers.local
  • terraform-providers.logentries
  • terraform-providers.logicmonitor
  • terraform-providers.mailgun
  • terraform-providers.matchbox
  • terraform-providers.metalcloud
  • terraform-providers.mongodbatlas
  • terraform-providers.mysql
  • terraform-providers.ncloud
  • terraform-providers.netlify
  • terraform-providers.newrelic
  • terraform-providers.nixos
  • terraform-providers.nomad
  • terraform-providers.ns1
  • terraform-providers.nsxt
  • terraform-providers.null
  • terraform-providers.nutanix
  • terraform-providers.oci
  • terraform-providers.okta
  • terraform-providers.oktaasa
  • terraform-providers.oneandone
  • terraform-providers.opc
  • terraform-providers.opennebula
  • terraform-providers.openstack
  • terraform-providers.opentelekomcloud
  • terraform-providers.opsgenie
  • terraform-providers.oraclepaas
  • terraform-providers.ovh
  • terraform-providers.packet
  • terraform-providers.pagerduty
  • terraform-providers.panos
  • terraform-providers.pass
  • terraform-providers.postgresql
  • terraform-providers.powerdns
  • terraform-providers.profitbricks
  • terraform-providers.pureport
  • terraform-providers.rabbitmq
  • terraform-providers.rancher
  • terraform-providers.rancher2
  • terraform-providers.random
  • terraform-providers.rightscale
  • terraform-providers.rundeck
  • terraform-providers.runscope
  • terraform-providers.scaleway
  • terraform-providers.secret
  • terraform-providers.segment
  • terraform-providers.selectel
  • terraform-providers.signalfx
  • terraform-providers.skytap
  • terraform-providers.softlayer
  • terraform-providers.sops
  • terraform-providers.spotinst
  • terraform-providers.stackpath
  • terraform-providers.statuscake
  • terraform-providers.sumologic
  • terraform-providers.telefonicaopencloud
  • terraform-providers.template
  • terraform-providers.tencentcloud
  • terraform-providers.terraform
  • terraform-providers.tfe
  • terraform-providers.tls
  • terraform-providers.triton
  • terraform-providers.turbot
  • terraform-providers.ucloud
  • terraform-providers.ultradns
  • terraform-providers.vault
  • terraform-providers.vcd
  • terraform-providers.venafi
  • terraform-providers.vra7
  • terraform-providers.vsphere
  • terraform-providers.vthunder
  • terraform-providers.vultr
  • terraform-providers.wavefront
  • terraform-providers.yandex
  • terraform_0_11-full
  • terraform_plugins_test
  • terragrunt

anandsuresh pushed a commit to anandsuresh/nixpkgs that referenced this pull request Jan 27, 2021
@Myhlamaeus @anandsuresh
terraform-providers: add version to patchGoModVendor providers (NixOS…
dbe5558 
…#97590)

Add version to binaries produced via patchGoModVendor to allow run-time provider
version validation by terraform.

This was initially introduced in 4e63119 (terraform: add the version component to terraform provider paths (NixOS#34497), 2018-02-06)
but broken in 3e5149a (terraform-providers: fix the google and google-beta providers, 2020-03-24)
for terraform-providers.google and terraform-providers.google-beta, and in 20f55a9 (terraform-providers.ibm: move to update-all script, 2020-04-26)
for terraform-providers.ibm.

(cherry picked from commit 94d2aeb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Myhlamaeus @zimbatm @Janik-Haag