Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aresponses,pyhaversion: disable for py2 #97560

Merged
merged 2 commits into from Sep 9, 2020
Merged

aresponses,pyhaversion: disable for py2 #97560

merged 2 commits into from Sep 9, 2020

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Sep 9, 2020

Motivation for this change

#97479 , should be back-ported to 20.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit b511854 into NixOS:master Sep 9, 2020
@Mic92
Copy link
Member

Mic92 commented Sep 9, 2020

both backported as well: 46f14c8

@makefu makefu deleted the pkgs/python-maintainer/fix-eval branch September 9, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makefu @Mic92