Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] Plasma 5: Revert to Qt 5.12 #97524

Merged
merged 6 commits into from Sep 9, 2020
Merged

[20.09] Plasma 5: Revert to Qt 5.12 #97524

merged 6 commits into from Sep 9, 2020

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Sep 9, 2020 •
edited

Motivation for this change

Plasma 5.18 only officially supports Qt 5.12.

I don't know what the procedure is for merging release-20.09 into staging-20.09, but I guess somebody needs to fast-forward the latter branch so I can rebase onto it with the latest changes from release-20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel added this to the 20.09 milestone Sep 9, 2020
@worldofpeace
Copy link
Contributor

I don't know what the procedure is for merging release-20.09 into staging-20.09, but I guess somebody needs to fast-forward the latter branch so I can rebase onto it with the latest changes from release-20.09.

I merged --no-ff release-20.09 into staging-20.09 👍

@ttuegel ttuegel merged commit 8d94bf0 into NixOS:staging-20.09 Sep 9, 2020
@vcunat vcunat mentioned this pull request Sep 23, 2020
Closed
@samuelgrf samuelgrf mentioned this pull request Sep 23, 2020
Closed
@est31
Copy link
Contributor

est31 commented Sep 26, 2020

Qt 5.13 is supported as well, and it would fix some failing builds like akonadi or digikam (#98879) and might help with #98536 too.

@est31
Copy link
Contributor

est31 commented Sep 26, 2020

Check the table here, it lists 5.12 and 5.13: https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series

@ttuegel
Copy link
Member Author

ttuegel commented Sep 27, 2020

Qt 5.13 is not an LTS release and we are outside its support window. The affected packages will be supported by upgrading to Qt 5.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: qt/kde 8.has: clean-up 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttuegel @worldofpeace @est31