Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/qt5ct: do not require qtstyleplugins #97596

Merged
merged 1 commit into from Sep 10, 2020
Merged

nixos/qt5ct: do not require qtstyleplugins #97596

merged 1 commit into from Sep 10, 2020

Conversation

gebner
Copy link
Member

@gebner gebner commented Sep 9, 2020

Motivation for this change

qtstyleplugins do not build with qt 5.15. Last upstream update is from four years ago.

AFAICT there is no reason to require them in the qt5ct module. (You can just add them via environment.systemPackages.)

cc @gnidorah who added the qtstyleplugins to the qt5ct module in the first place

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner
nixos/qt5ct: do not require qtstyleplugins
4bf695e 
These do not build with qt 5.15.
@gebner gebner added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 9, 2020
@gebner gebner merged commit 0256763 into NixOS:master Sep 10, 2020
@gebner
Copy link
Member Author

gebner commented Sep 10, 2020

Backported as 87aa949

@elohmeier elohmeier mentioned this pull request Sep 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gebner