Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-appservice-slack: 1.4.0 -> 1.6.1 #97598

Closed
wants to merge 1 commit into from

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Sep 9, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Sep 9, 2020

@GrahamcOfBorg build matrix-appservice-slack

@georgyo
Copy link
Contributor

georgyo commented Oct 12, 2020

This was seems to have fallen though the cracks and never merged.

@kampka I tried updating this to 1.6.0, however I get the following error which I can not reproduce outside of nix-build

npm ERR! Maximum call stack size exceeded loadAllDepsIntoIdealTrK

npm ERR! A complete log of this run can be found in:
npm ERR!     /build/.npm/_logs/2020-10-12T11_34_10_088Z-debug.log

builder for '/nix/store/ppysc1ddp3gzk96k05md2w54bm9p6kx5-node_matrix-appservice-slack-1.6.0.drv' failed with exit code 1
error: build of '/nix/store/ppysc1ddp3gzk96k05md2w54bm9p6kx5-node_matrix-appservice-slack-1.6.0.drv' failed

If I try nix-shell --pure default.nix -A matrix-appservice-slack I get a completely different error when running genericBuild

npm ERR! code ENOTCACHED
npm ERR! request to https://registry.npmjs.org/@types%2fjson-schema failed: cache mode is 'only-if-cached' but no cached response available.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/.npm/_logs/2020-10-12T11_36_08_165Z-debug.log

However if I run npm install && npm build it all works. I cannot figure out where and why the build process is failing.

@kampka
Copy link
Contributor Author

kampka commented Oct 21, 2020

@georgyo the thing with node2nix in the way that it is used here is, it does not pull in dependency version quite as specified in package.json and package-lock.json so using it to generate a working node-packages.nix, the stars and the npmjs repository and all the ancient gods have to agree that now is the time that it shall maybe work.
To make this more stable, the package would probably have to be rewritten, for which I currently lack the time, or node2nix would have to adjust / fix it's behavior in these cases.

@kampka
Copy link
Contributor Author

kampka commented Oct 22, 2020

Filed an issue for that: svanderburg/node2nix#207

@kampka kampka force-pushed the matrix-appservice-slack branch 2 times, most recently from f891dc6 to 8bc4c55 Compare October 26, 2020 22:25
@kampka kampka changed the title matrix-appservice-slack: 1.4.0 -> 1.5.0 matrix-appservice-slack: 1.4.0 -> 1.6.0 Oct 26, 2020
@kampka
Copy link
Contributor Author

kampka commented Oct 26, 2020

@GrahamcOfBorg build matrix-appservice-slack

@kampka kampka changed the title matrix-appservice-slack: 1.4.0 -> 1.6.0 matrix-appservice-slack: 1.4.0 -> 1.6.1 Nov 6, 2020
@kampka
Copy link
Contributor Author

kampka commented Nov 6, 2020

@GrahamcOfBorg build matrix-appservice-slack

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 18, 2021

@kampka ping

@kampka
Copy link
Contributor Author

kampka commented Jan 18, 2021

@SuperSandro2000 pong

@kampka
Copy link
Contributor Author

kampka commented Jan 20, 2021

Closing this as this package is now being removed for being unmaintained.

@kampka kampka closed this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants