Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/build: ensure drv eval didn't error #97571

Closed
wants to merge 1 commit into from
Closed

scripts/build: ensure drv eval didn't error #97571

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

If the package will throw an error, the current script doesn't inspect the derivation value, so it will later try to build something that error'd.

Added enough logic to inspect the value from the tryEval to prevent this

Example:

[10:26:57] jon@nixos-laptop ~/projects/nixpkgs (master)
$ nix-build maintainers/scripts/build.nix --argstr maintainer jonringer
unpacking 'https://github.com/nix-community/NUR/archive/master.tar.gz'...
error: azure-core-1.8.0 not supported for interpreter python2.7
(use '--show-trace' to show detailed location information)

with changes:

[10:29:08] jon@nixos ~/projects/nixpkgs (fix-maintainer-script)
$ nix-build maintainers/scripts/build.nix --argstr maintainer jonringer
[10:29:15] jon@nixos ~/projects/nixpkgs (fix-maintainer-script)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer mentioned this pull request Sep 9, 2020
Closed
@jonringer
Copy link
Contributor Author

cc @fgaz

@jonringer jonringer mentioned this pull request Sep 10, 2020
Merged
@erikarvstedt
Copy link
Member

This prevents building broken pkgs by building no pkgs at all. 😉
Reason: result.value is always a list, so lib.isDerivation result.value is always false.
Hence, packagesWith always returns an empty list of pkgs to build.

@jonringer
Copy link
Contributor Author

closing in favor of #97647

@jonringer jonringer closed this Sep 15, 2020
@jonringer jonringer deleted the fix-maintainer-script branch September 15, 2020 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @erikarvstedt