Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean: Accept hardcoded /tmp #97519

Closed
wants to merge 1 commit into from
Closed

clean: Accept hardcoded /tmp #97519

wants to merge 1 commit into from

Conversation

Lucus16
Copy link
Contributor

@Lucus16 Lucus16 commented Sep 9, 2020

Motivation for this change

This fixes a build failure caused by a /tmp path being detected as impure. Tested the compiler on some of my homework.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

I think the more proper fix would be to patch usages of /tmp to point to $TMPDIR

@Lucus16
Copy link
Contributor Author

Lucus16 commented Sep 9, 2020 via email

@vcunat
Copy link
Member

vcunat commented Sep 18, 2020

I don't think we'll need this. Those strictness checks were reverted (ATM on master and staging-20.09), because such unintended cases were breaking more stuff in practice than anticipated. A new version is planned in PR #97597 but it should be less strict and not give this problem.

@Lucus16
Copy link
Contributor Author

Lucus16 commented Sep 19, 2020

Yes, this became irrelevant, closing.

@Lucus16 Lucus16 closed this Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lucus16 @jonringer @vcunat