Several bugs found while bringing this to production #4
+64
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps in deployments to AWS to know if the server is done starting up.
aiohttp has this odd thing that it closes down the event-loop it is running in. This includes the transports. So by the time we exit from the run() function, those transports are already long gone.
Turns out, only the first package of a stream contains the proxy protocol header when using nginx. So we need to track the mapping.
TrueBrain
force-pushed
the
bugs_in_prod
branch
from
e9b7c69 to
005c756
Compare
frosch123
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits to find out what is being fixed.