Several bugs found while bringing this to production #5
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it is annoying Python is not lazy in resolving. Owh well, easy fix ;)
frosch123
reviewed
Sep 9, 2020
webclient/pages/servers.py
Outdated
|
|
||
| servers = _server_list_cache["servers"] | ||
| if filter != "all": | ||
| if filter is not None: |
There was a problem hiding this comment.
Could be just "if filter:".
Unless you want to test startswith("")
Maybe convert "" to None, to make it easier in the template?
TrueBrain
force-pushed
the
bugs_in_prod
branch
from
af1e57a to
307fd3c
Compare
frosch123
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently running on staging, at:
https://servers.staging.openttd.org/