Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] nodePackages.node-red: fix build #97506

Merged
merged 1 commit into from Sep 9, 2020
Merged

[20.03] nodePackages.node-red: fix build #97506

merged 1 commit into from Sep 9, 2020

Conversation

arapov
Copy link
Contributor

@arapov arapov commented Sep 9, 2020

Motivation for this change

resolves build issue #89205

Signed-off-by: Anton Arapov arapov@gmail.com
(cherry picked from commit e570171)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arapov
nodePackages.node-red: fix build
43a6e63 
resolves issue #89205

Signed-off-by: Anton Arapov <arapov@gmail.com>
(cherry picked from commit e570171)
@arapov arapov mentioned this pull request Sep 9, 2020
Closed
10 tasks
@worldofpeace worldofpeace merged commit 04ea219 into NixOS:release-20.03 Sep 9, 2020
@worldofpeace
Copy link
Contributor

I believe we should backport to 20.09 too?

@arapov
Copy link
Contributor Author

arapov commented Sep 9, 2020

I believe we should backport to 20.09 too?
sure, #97554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arapov @worldofpeace