sentencepiece: remove static library from the output #99645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
jonringer
reviewed
Oct 18, 2020
| , cmake | ||
| , gperftools | ||
|
|
||
| , enableStatic ? false |
There was a problem hiding this comment.
there should be a related:
sentencepiece = super.sentencepiece.override {
enableStatic = true;
};
in pkgs/top-level/static.nix
There was a problem hiding this comment.
Thanks! I have added this. I have also disabled building of shared libraries in static builds.
I also added a commit which puts gperftools in buildInputs rather than nativeBuildInputs.
However, building sentencepiece statically fails, because building gperftools fails with:
libtool: link: x86_64-unknown-linux-musl-g++ -std=gnu++11 -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -Wno-unused-result -fsized-deallocation -faligned-new -DNO_FRAME_POINTER -g -O2 -o stacktrace_unittest src/tests/stacktrace_unittest.o ./.libs/libstacktrace.a ./.libs/liblogging.a ./.libs/libfake_stacktrace_scope.a /nix/store/yzda7vvxr4zpmmlp5bfb22s075dm3dhf-x86_64-unknown-linux-musl-stage-final-gcc-debug-9.3.0-lib/x86_64-unknown-linux-musl/lib/../lib64/libstdc++.so -lm -Wl,-rpath -Wl,/nix/store/yzda7vvxr4zpmmlp5bfb22s075dm3dhf-x86_64-unknown-linux-musl-stage-final-gcc-debug-9.3.0-lib/x86_64-unknown-linux-musl/lib/../lib64 -Wl,-rpath -Wl,/nix/store/yzda7vvxr4zpmmlp5bfb22s075dm3dhf-x86_64-unknown-linux-musl-stage-final-gcc-debug-9.3.0-lib/x86_64-unknown-linux-musl/lib/../lib64
/nix/store/9nh6bp6w99kyjsa1gi6ynd3vxp1x66xl-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: attempted static link of dynamic object `/nix/store/yzda7vvxr4zpmmlp5bfb22s075dm3dhf-x86_64-unknown-linux-musl-stage-final-gcc-debug-9.3.0-lib/x86_64-unknown-linux-musl/lib/../lib64/libstdc++.so'
Seems to be the same issue as #76873.
Unfortunately, sentencepiece does provide a CMake option to disable static builds. So just remove it from the output, unless static builds are enabled.
danieldk
force-pushed
the
sentencepiece-remove-static
branch
from
6d7b39c
to
28adb93
Compare
|
I will close this PR for the time being, using sentencepiece as a shared library can currently lead to issues: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unfortunately, sentencepiece does provide a CMake option to disable
static builds. So just remove it from the output, unless static builds
are enabled.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)