Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python.pkgs.scikit-optimize: 0.6 -> 0.8.1 #99673

Merged
merged 1 commit into from Oct 11, 2020
Merged

[20.09] python.pkgs.scikit-optimize: 0.6 -> 0.8.1 #99673

merged 1 commit into from Oct 11, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 5, 2020 •
edited

Motivation for this change

ZHF: #97479

Backport of #97990

Fails on macos, but that should be fixed in master first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp @risicle
python.pkgs.scikit-optimize: 0.6 -> 0.8.1
f5c8b71 
This fixes the build of scikit-optimize.

(cherry picked from commit b8f130e)
@risicle risicle changed the title python.pkgs.scikit-optimize: 0.6 -> 0.8.1 [20.09] python.pkgs.scikit-optimize: 0.6 -> 0.8.1 Oct 5, 2020
@ofborg ofborg bot requested a review from costrouc October 5, 2020 23:37
@tricktron
Copy link
Member

Result of nixpkgs-review pr 99673 1

1 package marked as broken and skipped:
  • python37Packages.optuna
2 packages failed to build:
  • python37Packages.scikit-optimize
  • python38Packages.scikit-optimize

@risicle
Copy link
Contributor Author

risicle commented Oct 7, 2020

@tricktron on darwin, right? if so that will get fixed by #99891

@tricktron
Copy link
Member

@tricktron on darwin, right? if so that will get fixed by #99891

@risicle Yes on darwin. Ah great. Sorry I missed that one.

@risicle risicle mentioned this pull request Oct 10, 2020
Closed
jonringer
jonringer approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/99673
1 package failed to build:
python37Packages.optuna

2 packages built:
python37Packages.scikit-optimize python38Packages.scikit-optimize

@jonringer jonringer merged commit 37547b5 into NixOS:release-20.09 Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @tricktron @jonringer @knedlsepp