Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.pyspice: disable python<3.6 #99675

Merged
merged 1 commit into from Oct 5, 2020
Merged

python2Packages.pyspice: disable python<3.6 #99675

merged 1 commit into from Oct 5, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 5, 2020 •
edited

Motivation for this change

follow up to: #99634

builder for '/nix/store/mr29wsg5hzvn22gicqwac3ci1xyd9a0g-python2.7-PySpice-1.4.3.drv' failed with exit code 1; last 10 log lines:
  unpacking sources
  unpacking source archive /nix/store/d2cp7aq5mpks8c1hyfw45hviw7r25f35-PySpice-1.4.3.tar.gz
  source root is PySpice-1.4.3
  setting SOURCE_DATE_EPOCH to timestamp 1593798877 of file PySpice-1.4.3/setup.cfg
  patching sources
  configuring
  no configure script, doing nothing
  building
  Executing setuptoolsBuildPhase
  ERROR: PySpice requires Python 3.6
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix-env -f /home/jon/.cache/nixpkgs-review/pr-99675/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages removed:
python2.7-PySpice (†1.4.3) python2.7-skidl-unstable (†2020-09-15)

@jonringer jonringer requested a review from FRidh as a code owner October 5, 2020 23:27
matthuszagh
matthuszagh reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@matthuszagh matthuszagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jonringer jonringer merged commit 0cdf133 into NixOS:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthuszagh matthuszagh matthuszagh approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @matthuszagh