Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epgstation: 1.7.4 -> 1.7.5 #99632

Merged
merged 2 commits into from Nov 3, 2020
Merged

epgstation: 1.7.4 -> 1.7.5 #99632

merged 2 commits into from Nov 3, 2020

Conversation

midchildan
Copy link
Member

Motivation for this change
  • bump version
  • change existing scripts to make use of passthru.updateScript
  • change name from node_EPGStation to EPGStation.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@midchildan midchildan changed the title Update/epgstation epgstation: 1.7.4 -> 1.7.5 Oct 5, 2020
@midchildan
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 6, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

wamserma
wamserma approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at first glance.

@wamserma
Copy link
Member

wamserma commented Nov 2, 2020

/marvin needs_merger

@midchildan
Copy link
Member Author

Thanks! JFYI the command for changing statuses is /status.

/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 3, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@midchildan
Copy link
Member Author

Oh.

@wamserma
Copy link
Member

wamserma commented Nov 3, 2020

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau November 3, 2020 06:17
@wamserma
Copy link
Member

wamserma commented Nov 3, 2020

Thanks! JFYI the command for changing statuses is /status.

/status needs_merger

I always mix this up. -.-

timokau
timokau approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @cideM, what is the status on node packages? Should I just merge this or do you want to bundle it somehow?

@cideM
Copy link
Contributor

cideM commented Nov 3, 2020 •
edited

Since there are no conflicts I'd just merge this right now. For follow-up merge conflicts I'd then bundle them

@timokau
Copy link
Member

timokau commented Nov 3, 2020

Okay, thanks! Also thank you for the review @wamserma.

@timokau timokau merged commit 6c13df3 into NixOS:master Nov 3, 2020
@midchildan midchildan deleted the update/epgstation branch November 4, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@midchildan @wamserma @cideM @timokau