Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mblaze: 0.5.1 -> 1.0 #99628

Merged
merged 1 commit into from Oct 6, 2020
Merged

mblaze: 0.5.1 -> 1.0 #99628

merged 1 commit into from Oct 6, 2020

Conversation

justinlovinger
Copy link
Contributor

Motivation for this change

Update mblaze. It has since changed owner and was very out of date.

The patch is no longer necessary.

I also took the liberty of updating shell completion installation to use installShellCompletion.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of most binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ajgrf October 5, 2020 14:47
danieldk
danieldk approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. It seems that these program need to be properly wrapped or patched:

$ wrapit `realpath results/mblaze/bin/mscan`
mscan: spawning pager 'less -R': No such file or directory
could not read sequence '/home/daniel/.mblaze/seq': No such file or directory

But that can be done in a separate PR.

Result of nixpkgs-review pr 99628 1

1 package built:
  • mblaze

@danieldk danieldk merged commit 6f90e1d into NixOS:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@ajgrf ajgrf Awaiting requested review from ajgrf

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinlovinger @danieldk