Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl8812au: 5.6.4.2_35491.20200318 -> 5.6.4.2_35491.20200702 #99651

Merged
merged 1 commit into from Oct 5, 2020
Merged

rtl8812au: 5.6.4.2_35491.20200318 -> 5.6.4.2_35491.20200702 #99651

merged 1 commit into from Oct 5, 2020

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I do not have this hardware but the build works now :)

Ping @NixOS/nixos-release-managers

@ofborg ofborg bot removed the 6.topic: kernel label Oct 5, 2020
@ofborg ofborg bot requested a review from danielfullmer October 5, 2020 20:03
jonringer
jonringer approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99651 1

17 packages built:
  • linuxPackages-libre.rtl8812au
  • linuxPackages.rtl8812au
  • linuxPackages_4_14.rtl8812au
  • linuxPackages_4_19.rtl8812au
  • linuxPackages_4_4.rtl8812au
  • linuxPackages_4_9.rtl8812au
  • linuxPackages_5_7.rtl8812au
  • linuxPackages_5_8.rtl8812au
  • linuxPackages_hardened.rtl8812au
  • linuxPackages_latest-libre.rtl8812au
  • linuxPackages_latest_hardened.rtl8812au
  • linuxPackages_latest_xen_dom0.rtl8812au
  • linuxPackages_latest_xen_dom0_hardened.rtl8812au
  • linuxPackages_testing_bcachefs.rtl8812au
  • linuxPackages_xen_dom0.rtl8812au
  • linuxPackages_xen_dom0_hardened.rtl8812au
  • linuxPackages_zen.rtl8812au

@jonringer jonringer merged commit ce79348 into NixOS:master Oct 5, 2020
@NeQuissimus NeQuissimus deleted the rtl8812au_20200702 branch October 5, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@danielfullmer danielfullmer Awaiting requested review from danielfullmer

Assignees
No one assigned
Labels
6.topic: hardware 8.has: package (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @jonringer