Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caffeine-ng: add missing dependencies, fix bin paths #99667

Merged
merged 1 commit into from Oct 13, 2020
Merged

caffeine-ng: add missing dependencies, fix bin paths #99667

merged 1 commit into from Oct 13, 2020

Conversation

uvNikita
Copy link
Contributor

@uvNikita uvNikita commented Oct 5, 2020 •
edited

Motivation for this change

caffeine-ng makes os.system calls expecting some binaries in the path, see inhibitors.py file. This PR adds missing dependencies and patches mentioned file to use binaries from the nix store.

Closure size change: 376.3M -> 509.3M

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from marzipankaiser October 5, 2020 22:23
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/334

@veprbl veprbl merged commit 6cc0fc9 into NixOS:master Oct 13, 2020
veprbl pushed a commit that referenced this pull request Oct 13, 2020
@uvNikita @veprbl
caffeine-ng: add missing dependencies, fix bin paths
22d8599 
(cherry picked from commit 35e0d35)
cc #99667
@veprbl veprbl added 9.needs: port to stable A PR needs a backport to the stable release. 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 13, 2020
@uvNikita uvNikita deleted the caffeine-ng/fix-bin-paths branch October 14, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@marzipankaiser marzipankaiser Awaiting requested review from marzipankaiser

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uvNikita @nixos-discourse @veprbl