New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-python-libraries: add github fetcher #99635
Conversation
The sha is being incorrectly calculated :( |
ah, had to pass The other option would be to change the sha into a known "bad" sha, and then see what nix-build complains about. This would be resilient to people passing "name" to |
88fb619
to
28cd3e6
Compare
built around 8000 python packages, didn't see any sha errors |
pkgs/development/interpreters/python/update-python-libraries/update-python-libraries.py
Outdated
Show resolved
Hide resolved
28cd3e6
to
908300f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! If it all works then go ahead and merge it.
pkgs/development/interpreters/python/update-python-libraries/update-python-libraries.py
Outdated
Show resolved
Hide resolved
908300f
to
484748e
Compare
Motivation for this change
was tired of it only supporting pypi
I use the
nix eval -f <NIXPKGS_ROOT>/default.nix python3Packages.<package>.src.meta.homepage
to determine the owner and repo. NIXPKGS_ROOT is determined from script location, not an environment variable though.Some limitations:
GITHUB_API_TOKEN
(taken from vim plugin conventions) is not given, then user will be limited to 100 api requests; instead of 5000If an update does fail, the entire update job will still succeed, similar to existing behavior.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)